[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arkodg
Once this PR has been reviewed and has the lgtm label, please assign nak3 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Welcome @arkodg! It looks like this is your first PR to knative-sandbox/net-gateway-api 🎉

Hi @arkodg. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

ptal @dprotaso @evankanderson

/ok-to-test

Codecov Report

Merging #469 (15641ff) into main (17e08b5) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   72.76%   72.47%   -0.30%     
==========================================
  Files           9        9              
  Lines         683      683              
==========================================
- Hits          497      495       -2     
- Misses        157      159       +2     
  Partials       29       29              

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

looks like all tests failed, unable to spot the misconfiguration 😭

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.