Skip to content

Update outdated Kourier url #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Jun 23, 2025
Merged

Update outdated Kourier url #587

knative-prow merged 1 commit into from
Jun 23, 2025

Conversation

@seb-goodman
Copy link
Contributor

@seb-goodman seb-goodman commented Jun 23, 2025

Changes

  • Updates the Kourier Github url to reflect the renaming of knative-sandbox to knative-extensions.

/kind bug, deprecation

The old url breaks environments using mirrors where automatic redirection is not in place. Mirrors are sometimes used in regulated industries which need to control code dependencies.

Release Note

Updated the Kourier GitHub URL to support users in air-gapped or mirrored environments.

@knative-prow
Copy link

knative-prow bot commented Jun 23, 2025

@seb-goodman: The label(s) kind/bug, cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

  • Updates the Kourier Github url to reflect the renaming of knative-sandbox to knative-extensions.

/kind bug, deprecation

The old url breaks environments using mirrors where automatic redirection is not in place. Mirrors are sometimes used in regulated industries which need to control code dependencies.

Release Note

Updated the Kourier GitHub URL to support users in air-gapped or mirrored environments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Jun 23, 2025
@knative-prow knative-prow bot requested review from dsimansk and psschwei June 23, 2025 10:19
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 23, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@knative-prow
Copy link

knative-prow bot commented Jun 23, 2025

Welcome @seb-goodman! It looks like this is your first PR to knative-extensions/kn-plugin-quickstart 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 23, 2025
@knative-prow
Copy link

knative-prow bot commented Jun 23, 2025

Hi @seb-goodman. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2025
@psschwei
Copy link
Member

psschwei commented Jun 23, 2025

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 23, 2025
psschwei
psschwei reviewed Jun 23, 2025
View reviewed changes
Copy link
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2025
@knative-prow
Copy link

knative-prow bot commented Jun 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei, seb-goodman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2025
@knative-prow knative-prow bot merged commit 36c379c into knative-extensions:main Jun 23, 2025
18 checks passed
@seb-goodman seb-goodman deleted the patch-1 branch June 23, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

1 more reviewer

@psschwei psschwei psschwei left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@psschwei psschwei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seb-goodman @psschwei