Install from the manifest in a strict(er) order. #374
Conversation
This order, Roles -> RoleBindings -> The Rest, prevents the operand from needing to structure their manifest such that this ordering exists, while allowing the Operator to use the bootstrapping mechanism described in knative#291 to 'escalate' itself into management of the Knative Serving installation without a *** clusterrole.
Cynocracy
changed the title
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@Cynocracy: 0 warnings.
Details
In response to this:
This order, Roles -> RoleBindings -> The Rest, prevents the operand from
needing to structure their manifest such that this ordering exists, while
allowing the Operator to use the bootstrapping mechanism described in
#291 to 'escalate' itself
into management of the Knative Serving installation without a *** clusterrole.Proposed Changes
- Install roles, then rolebindings, then the remainder of the manifest.
Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)
|
Will probably need to find a different assignee :( |
|
/lgtm |
jcrossley3
left a comment
jcrossley3
left a comment
There was a problem hiding this comment.
Looks good. Comment on my nit and I'll approve.
|
Thanks for the review :) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cynocracy, jcrossley3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 participants
This order, Roles -> RoleBindings -> The Rest, prevents the operand from
needing to structure their manifest such that this ordering exists, while
allowing the Operator to use the bootstrapping mechanism described in
#291 to 'escalate' itself
into management of the Knative Serving installation without a *** clusterrole.
Proposed Changes
Release Note