Skip to content
This repository was archived by the owner on Jun 24, 2020. It is now read-only.

Cherry pick for release 0.12 to support KUBECONFIG in OLM #299

Merged
knative-prow-robot merged 4 commits into from
Feb 18, 2020
Merged

Cherry pick for release 0.12 to support KUBECONFIG in OLM #299

knative-prow-robot merged 4 commits into from
Feb 18, 2020

Conversation

@houshengbo
Copy link

@houshengbo houshengbo commented Feb 17, 2020 •
edited
Loading

Proposed Changes

  • This is a cherry-pick of the commit a4d4f70 and commit e783cf5. Additional fixes have been done as well to resolve the conflicts or errors.
  • Update the library from jcrossley/manifestival to manifestival/manifestival.

Release Note

@googlebot
Copy link

googlebot commented Feb 17, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

knative-prow-robot
knative-prow-robot reviewed Feb 17, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houshengbo: 0 warnings.

Details

In response to this:

Proposed Changes

  • This is a cherry-pick of the commit a4d4f70.

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@houshengbo
Copy link
Author

houshengbo commented Feb 17, 2020

@googlebot I consent.

@houshengbo houshengbo changed the title Support reading KubeConfig from KUBECONFIG env var (#293) Cherry pick for release 0.12 Feb 17, 2020
Add upgrade tests into the e2e-tests-latest-serving (knative#286)
3b9f41a 
* Add upgrade tests into the e2e-tests-latest-serving

This PR adds the tests to verify the correct number and names of knative serving
deployments.

The test tag postupgrade is added, marking the tests to run after upgrade to the
latest HEAD of operator, with the latest generated manifest of knative serving.

* Install the latest release of the operator and then upgrade

* Split the long functions and rename the common package

* Refactor the PR based on the comments
@houshengbo houshengbo changed the title Cherry pick for release 0.12 Cherry pick for release 0.12 to support KUBECONFIG in OLM Feb 17, 2020
@aliok
Copy link
Member

aliok commented Feb 17, 2020

@googlebot I consent

@googlebot
Copy link

googlebot commented Feb 17, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Author(s) signed a CLA. and removed cla: no labels Feb 17, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@houshengbo
Copy link
Author

houshengbo commented Feb 18, 2020

/hold I have new findings, still verifying.

@houshengbo
Copy link
Author

houshengbo commented Feb 18, 2020

/hold cancel

@knative-metrics-robot
Copy link

knative-metrics-robot commented Feb 18, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-serving-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/knativeserving/common/images.go 85.1% 87.3% 2.2

@k4leung4
Copy link
Contributor

k4leung4 commented Feb 18, 2020

/lgtm

@knative-prow-robot knative-prow-robot merged commit d3e3d2e into knative:release-0.12 Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bbrowning bbrowning Awaiting requested review from bbrowning

@greghaynes greghaynes Awaiting requested review from greghaynes

3 more reviewers

@mattmoor mattmoor mattmoor left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@aliok aliok aliok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@k4leung4 k4leung4

Labels

approved cla: yes Author(s) signed a CLA. lgtm size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@houshengbo @googlebot @aliok @knative-prow-robot @knative-metrics-robot @k4leung4 @mattmoor