Skip to content
This repository was archived by the owner on Jun 24, 2020. It is now read-only.

Conversation

@houshengbo
Copy link

@houshengbo houshengbo commented Feb 6, 2020

Fixes #287

Proposed Changes

  • We rename this script, since we would like to use it as a base to do upgrade tests.
  • Customize the function integration_tests to make sure the integration tests only run the script e2e-tests.sh.

Release Note


Copy link
Contributor

@jcrossley3 jcrossley3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/upgrate/upgrade/

@houshengbo houshengbo force-pushed the rename-integration-job branch from d74f7b0 to b95e1fa Compare February 6, 2020 20:30
@houshengbo houshengbo changed the title Rename e2e-tests-latest-serving.sh into e2e-upgrate-tests.sh Rename e2e-tests-latest-serving.sh into e2e-upgrade-tests Feb 6, 2020
Copy link
Contributor

@jcrossley3 jcrossley3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, jcrossley3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [houshengbo,jcrossley3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@houshengbo houshengbo force-pushed the rename-integration-job branch from b95e1fa to 4508eea Compare February 6, 2020 21:55
@houshengbo houshengbo force-pushed the rename-integration-job branch 6 times, most recently from 2f109f3 to 329f79a Compare February 7, 2020 16:37
@houshengbo houshengbo force-pushed the rename-integration-job branch from 329f79a to 0d3f58c Compare February 7, 2020 17:13
@jcrossley3
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot merged commit b592cf1 into knative:master Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade tests to be added into this repo to test the upgrade of operator with knative serving

4 participants