-
Notifications
You must be signed in to change notification settings - Fork 44
OLM metadata #263
OLM metadata #263
Conversation
|
Hi @aliok. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f5b0726 to
b586ef8
Compare
houshengbo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm nice!
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@aliok: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/lgtm |
Fixes #261
Proposed Changes
hack/generate-olm-catalog-source.sh. This is to generate OLM catalog source from OLM metadata and thus to test the operator with OLM.Release Note
Verification instructions on Minikube:
CatalogSourceusing the instructions in the modified READMEA. Create operator subscription using the instructions in the modified README
B. Optional: run OLM console locally targeting Minikube, install the operator using the OLM console (OperatorHub --> Knative Eventing --> Install Operator) and then install Knative CR using the UI too (Installed Operators --> Knative Eventing --> Create Instance)
Note that, I will submit a PR to OperatorHub with this metadata once we merge this PR.
cc @houshengbo @jcrossley3