Skip to content
This repository was archived by the owner on Jun 24, 2020. It is now read-only.

Conversation

@aliok
Copy link
Member

@aliok aliok commented Jan 22, 2020

Fixes #261

Proposed Changes

  • Check in OLM metadata. That is to be submitted to OperatorHub
  • Check in hack/generate-olm-catalog-source.sh. This is to generate OLM catalog source from OLM metadata and thus to test the operator with OLM.
  • Add documentation in README around how to test OLM integration

Release Note

NONE

Verification instructions on Minikube:

Note that, I will submit a PR to OperatorHub with this metadata once we merge this PR.

cc @houshengbo @jcrossley3

@knative-prow-robot
Copy link
Contributor

Hi @aliok. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aliok aliok force-pushed the initial-olm-metadata branch from f5b0726 to b586ef8 Compare January 22, 2020 12:48
Copy link

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm nice!

@houshengbo
Copy link

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok
Copy link
Member Author

aliok commented Jan 23, 2020

/retest

@knative-prow-robot
Copy link
Contributor

@aliok: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aliok aliok changed the title OLM metadata fixes #261 OLM metadata Jan 23, 2020
@houshengbo
Copy link

/ok-to-test

@houshengbo
Copy link

/lgtm

@knative-prow-robot knative-prow-robot merged commit 68d322f into knative:master Jan 23, 2020
@aliok aliok deleted the initial-olm-metadata branch January 24, 2020 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OLM metadata

5 participants