Skip to content
This repository was archived by the owner on Jun 24, 2020. It is now read-only.

Drop knative.dev/serving as dependency #249

Merged
knative-prow-robot merged 1 commit into from
Jan 13, 2020
Merged

Drop knative.dev/serving as dependency #249

knative-prow-robot merged 1 commit into from
Jan 13, 2020

Conversation

@skaslev
Copy link

@skaslev skaslev commented Jan 9, 2020

Since 7a6abca serving-operator is no longer using serving's
Istio client so there's no need depending on knative.dev/serving anymore.

Drop knative.dev/serving as dependency
cc20f6f 
Since 7a6abca serving-operator is no longer using serving's
Istio client so there's no need depending on knative.dev/serving anymore.
@googlebot googlebot added the cla: yes Author(s) signed a CLA. label Jan 9, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jan 9, 2020

Hi @skaslev. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skaslev
Copy link
Author

skaslev commented Jan 9, 2020

/cc @houshengbo

@k4leung4
Copy link
Contributor

k4leung4 commented Jan 9, 2020

/ok-to-test

houshengbo
houshengbo approved these changes Jan 13, 2020
View reviewed changes
Copy link

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jan 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, skaslev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 80c4c8c into knative:master Jan 13, 2020
@skaslev skaslev deleted the drop-serving branch January 14, 2020 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bbrowning bbrowning Awaiting requested review from bbrowning

1 more reviewer

@houshengbo houshengbo houshengbo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@houshengbo houshengbo

Labels

approved cla: yes Author(s) signed a CLA. lgtm ok-to-test size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skaslev @knative-prow-robot @k4leung4 @houshengbo @googlebot