Skip to content
This repository was archived by the owner on Jun 24, 2020. It is now read-only.

Conversation

@skaslev
Copy link

@skaslev skaslev commented Dec 4, 2019

Proposed Changes

knative.dev/pkg and knative.dev/serving got recently migrated to isito.io/client-go apis (knative/pkg#882 and knative/serving#6041).

This PR migrates serving-operator and updates knative.dev/pkg to latest master.

/lint

@googlebot googlebot added the cla: yes Author(s) signed a CLA. label Dec 4, 2019
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skaslev: 0 warnings.

Details

In response to this:

Proposed Changes

knative.dev/pkg and knative.dev/serving got recently migrated to isito.io/client-go apis (knative/pkg#882 and knative/serving#6041).

This PR migrates serving-operator and updates knative.dev/pkg to latest master.

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

Hi @skaslev. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k4leung4
Copy link
Contributor

k4leung4 commented Dec 4, 2019

/ok-to-test

@houshengbo
Copy link

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, skaslev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 4a2430b into knative:master Dec 11, 2019
@skaslev skaslev deleted the istio-apis branch January 9, 2020 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants