This repository was archived by the owner on Jun 24, 2020. It is now read-only.
Delete manifest resources in a finalizer #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@jcrossley3: 1 warning.
Details
In response to this:
This should be more predictable and thread-safe, i.e. The Right Way.
Fixes #
Proposed Changes
- Delete manifest resources in a finalizer instead of after the
KnativeServingresource is already gone.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This should be more predictable and thread-safe, i.e. The Right Way.
jcrossley3
force-pushed
the
delete-in-finalizer
branch
from
a16347d to
4386bb0
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcrossley3, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be more predictable and thread-safe, i.e. The Right Way.
Proposed Changes
KnativeServingresource is already gone.