Add test for version consistency #224
Conversation
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@aliok: 0 warnings.
Details
In response to this:
Fixes #201
Proposed Changes
- Add a test that compares the version in
version.goand theserving.knative.dev/releaselabels for resources in Knative serving YAMLRelease Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
Hi @aliok. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @jcrossley3 |
|
/ok-to-test |
|
@jcrossley3 here is a test that checks versions w/ deployments |
jcrossley3
left a comment
jcrossley3
left a comment
There was a problem hiding this comment.
Very nice! Ultimately, I don't love the fact that we have versions in two places -- the manifest itself and the version.go file -- but until we have a single place, I like having this test!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, jcrossley3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 participants
Fixes #201
Ported from eventing operator, knative/eventing-operator#42
Proposed Changes
version.goand theserving.knative.dev/releaselabels for resources in Knative serving YAMLRelease Note