Configure controller to trust registries with self-signed certs #219
Conversation
Modified CRD and ran update-codegen.sh
An e2e test will require a well-known self-signed registry, but I did verify it worked manually
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@jcrossley3: 4 warnings.
Details
In response to this:
Fixes #210
Proposed Changes
- Add configuration to the
KnativeServingCRD- Use that config to setup the
VolumeMountsandEnvVarsin the controller deployment per https://knative.dev/docs/serving/tag-resolution/
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
jcrossley3
force-pushed
the
custom-certs
branch
from
a6a4d67 to
7ec6004
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This seems wrong, but maybe not quite as wrong as the client sending empty structs for all the optional fields in the CR.
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcrossley3, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 participants
Fixes #210
Proposed Changes
KnativeServingCRDVolumeMountsandEnvVarsin the controller deployment per https://knative.dev/docs/serving/tag-resolution/