Skip to content
This repository was archived by the owner on Jun 24, 2020. It is now read-only.

Conversation

@jcrossley3
Copy link
Contributor

I think this is "The Right Way" to do it, but I could be wrong. Makes
the code a bit smaller anyway.

Fixes #20 (comment)

I think this is "The Right Way" to do it, but I could be wrong. Makes
the code a bit smaller anyway.
@googlebot googlebot added the cla: yes Author(s) signed a CLA. label Nov 8, 2019
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcrossley3: 0 warnings.

Details

In response to this:

I think this is "The Right Way" to do it, but I could be wrong. Makes
the code a bit smaller anyway.

Fixes #20 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trshafer
Copy link
Contributor

trshafer commented Nov 9, 2019

Thanks for doing this!

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcrossley3, trshafer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jcrossley3,trshafer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/knativeserving/common/images.go 84.1% 86.2% 2.1

@trshafer
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot merged commit f0de129 into knative:master Nov 11, 2019
@jcrossley3 jcrossley3 deleted the convert branch November 11, 2019 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants