Skip to content

Conversation

@chaodaiG
Copy link
Contributor

This script was duplicated in previous PR, removing the old one

/assign @chizhg

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 26, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 26, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Feb 26, 2020
@chaodaiG
Copy link
Contributor Author

/test pull-knative-serving-autotls-tests

@chaodaiG
Copy link
Contributor Author

/retest

@chizhg
Copy link
Contributor

chizhg commented Feb 26, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests pull-knative-serving-unit-tests
pull-knative-serving-unit-tests
pull-knative-serving-unit-tests
3/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-unit-tests

@knative-prow-robot knative-prow-robot merged commit 058b5a4 into knative:master Feb 26, 2020
@pmorie pmorie mentioned this pull request Feb 27, 2020
mattmoor added a commit that referenced this pull request Feb 27, 2020
knative-prow-robot pushed a commit that referenced this pull request Feb 27, 2020
chaodaiG added a commit to chaodaiG/serving that referenced this pull request Feb 27, 2020
knative-prow-robot pushed a commit that referenced this pull request Feb 27, 2020
@chaodaiG chaodaiG deleted the remove_old branch March 4, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants