Skip to content

Migrate serving to istio.io/client-go apis #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow-robot merged 2 commits into from
Nov 26, 2019
Merged

Migrate serving to istio.io/client-go apis #6041

knative-prow-robot merged 2 commits into from
Nov 26, 2019

Conversation

@skaslev
Copy link
Contributor

@skaslev skaslev commented Nov 15, 2019 •
edited
Loading

Proposed Changes

Migrate serving to istio.io/client-go apis.

Fixes #5969
Fixes #5936

/lint

Not for merging yet since it depends on knative/pkg#882 and is temporarily pinned to github.com/skaslev/pkg/tree/istio-apis2 for testing.

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 15, 2019
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Nov 15, 2019
knative-prow-robot
knative-prow-robot reviewed Nov 15, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skaslev: 0 warnings.

Details

In response to this:

Proposed Changes

Migrate serving to istio.io/client-go apis.

Fixes #5969 #5936

/lint

Not for merging yet since it depends on knative/pkg#882 and is temporarily pinned to github.com/skaslev/pkg/tree/istio-apis2 for testing.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 15, 2019

Hi @skaslev. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 15, 2019
@skaslev
Copy link
Contributor Author

skaslev commented Nov 15, 2019 •
edited
Loading

One issue I stumbled upon with this migration was that Istio's PortSelector.Name, which Knative is using, got removed recently.

@tcnghia @mattmoor any suggestions how to handle this?

@mattmoor
Copy link
Member

mattmoor commented Nov 15, 2019

If I'm not mistaken, we only ever pass an int anyways:

serving/pkg/reconciler/route/resources/ingress.go

Line 179 in 5617874

ServicePort: intstr.FromInt(int(networking.ServicePort(t.Protocol))),

cc @tcnghia WDYT?

@skaslev skaslev mentioned this pull request Nov 15, 2019
Merged
@vagababov
Copy link
Contributor

vagababov commented Nov 15, 2019

I don't think we use names there, no.

coryrc
coryrc reviewed Nov 15, 2019
View reviewed changes
@tcnghia
Copy link
Contributor

tcnghia commented Nov 15, 2019

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 15, 2019
@skaslev
Copy link
Contributor Author

skaslev commented Nov 17, 2019

/test pull-knative-serving-unit-tests

markusthoemmes
markusthoemmes reviewed Nov 20, 2019
View reviewed changes
@skaslev
Copy link
Contributor Author

skaslev commented Nov 20, 2019

/retest

@skaslev skaslev mentioned this pull request Nov 20, 2019
Closed
3 tasks
@skaslev
Copy link
Contributor Author

skaslev commented Nov 22, 2019

/assign @tcnghia

@skaslev skaslev mentioned this pull request Nov 26, 2019
Merged
@skaslev
Copy link
Contributor Author

skaslev commented Nov 26, 2019

/retest

@knative-test-reporter-robot
Copy link

knative-test-reporter-robot commented Nov 26, 2019

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/activator/net.TestMultipleActivators

@skaslev
Copy link
Contributor Author

skaslev commented Nov 26, 2019

pkg/activator/net.TestMultipleActivators seems to be flaking since this PR doesn't affect it at all.

/retest

@skaslev
Copy link
Contributor Author

skaslev commented Nov 26, 2019

/test pull-knative-serving-go-coverage

@knative-metrics-robot
Copy link

knative-metrics-robot commented Nov 26, 2019

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/ingress/resources/virtual_service.go 86.5% 86.1% -0.4

@skaslev
Copy link
Contributor Author

skaslev commented Nov 26, 2019

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2019
mattmoor
mattmoor reviewed Nov 26, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, skaslev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2019
@knative-prow-robot knative-prow-robot merged commit 197028d into knative:master Nov 26, 2019
@skaslev skaslev deleted the istio-apis2 branch November 28, 2019 13:52
@skaslev skaslev mentioned this pull request Dec 4, 2019
Merged
nak3 added a commit to nak3/serving that referenced this pull request Dec 5, 2019
@nak3
Remove workaround to avoid empy SubjectAltNames
cdee78b 
This patch removes a workaround to avoid empty SubjectAltNames, which
is introudce by:

knative@d528a69#diff-5adf7106f7f21606140cf8ecdb0bcc92R104

The issue should have been solved by
knative#6041.
nak3 added a commit to nak3/serving that referenced this pull request Dec 5, 2019
@nak3
Remove workaround to avoid empty SubjectAltNames
dc6e833 
This patch removes a workaround to avoid empty SubjectAltNames, which
is introudce by:

knative@d528a69#diff-5adf7106f7f21606140cf8ecdb0bcc92R104

The issue should have been solved by
knative#6041.
nak3 added a commit to nak3/serving that referenced this pull request Dec 5, 2019
@nak3
Remove workaround to avoid empty SubjectAltNames
d558fad 
This patch removes a workaround to avoid empty SubjectAltNames, which
is introduced by:

knative@d528a69#diff-5adf7106f7f21606140cf8ecdb0bcc92R104

The issue should have been solved by
knative#6041.
This was referenced Dec 5, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@chizhg chizhg Awaiting requested review from chizhg

@dgerd dgerd Awaiting requested review from dgerd

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

@vagababov vagababov Awaiting requested review from vagababov

+3 more reviewers

@markusthoemmes markusthoemmes markusthoemmes left review comments

@mattmoor mattmoor mattmoor left review comments

@coryrc coryrc coryrc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tcnghia tcnghia

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate to use istio/client-go Networking-istio pod: Failed to list *v1alpha3.Gateway

10 participants

@skaslev @knative-prow-robot @mattmoor @vagababov @tcnghia @knative-test-reporter-robot @knative-metrics-robot @markusthoemmes @coryrc @googlebot