Update RevisionSpec to use corev1.Container instead of ContainerSpec #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
approved these changes
Feb 14, 2018
Member
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
This is awesome. We should probably have follow-up issues for validating:
- If there are features of
corev1.Containerwe want to disallow, we should validate them out. - Add testing that we properly pass through features like
ReadinessCheck.
Member
There was a problem hiding this comment.
I believe we can remove these too. Is anything keying off of the options these contain right now?
Contributor
Author
There was a problem hiding this comment.
I'll do this in a follow-up CL.
pkg/controller/revision/ela_pod.go
Outdated
Member
There was a problem hiding this comment.
I think that this should almost entirely be pass-thru.
Can we start with: elaContainer := u.Spec.ContainerSpec.DeepCopy() and mutate it with our additions?
pkg/webhook/webhook_test.go
Outdated
Member
There was a problem hiding this comment.
This can be abbreviated as:
Env: []corev1.EnvVar{}
Name: envVarName,
Value: envVarValue,
}},
Contributor
Author
added 3 commits
February 14, 2018 13:25
This was mostly a drop-in replacement, except that I updated the Env specification to use corev1.Container.Env instead of being a top-level field on RevisionSpec. Fixes #17.
lberk
pushed a commit
to lberk/serving
that referenced
this pull request
Jul 4, 2019
Resolve only v1alpha1 CRDs until we're on OpenShift 4.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mostly a drop-in replacement, except that I updated the Env
specification to use corev1.Container.Env instead of being a top-level
field on RevisionSpec.
Fixes #17.