Skip to content

Unpin github.com/gorilla/websocket#15515

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
ReToCode:revert-gorilla-pin
Sep 18, 2024
Merged

Unpin github.com/gorilla/websocket#15515
knative-prow[bot] merged 1 commit intoknative:mainfrom
ReToCode:revert-gorilla-pin

Conversation

@ReToCode
Copy link
Copy Markdown
Contributor

Fixes #14597

Proposed Changes

/assign @skonto

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2024
@knative-prow knative-prow bot requested review from izabelacg and skonto September 17, 2024 13:44
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (cc9b060) to head (90d463f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15515      +/-   ##
==========================================
+ Coverage   84.47%   84.50%   +0.02%     
==========================================
  Files         219      219              
  Lines       13608    13608              
==========================================
+ Hits        11496    11499       +3     
+ Misses       1741     1739       -2     
+ Partials      371      370       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Copy Markdown
Contributor

skonto commented Sep 17, 2024

/lgtm
/approve

/hold have you checked the logs printed if they are too verbose?

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Sep 17, 2024
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ReToCode
Copy link
Copy Markdown
Contributor Author

/unhold

We initially had a failed build, thus the pinning. The verbose log was in 1.5.1 which we did not use.

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2024
@knative-prow knative-prow bot merged commit b796321 into knative:main Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump gorilla websocket to 1.5.1+

2 participants