Unpin github.com/gorilla/websocket#15515
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15515 +/- ##
==========================================
+ Coverage 84.47% 84.50% +0.02%
==========================================
Files 219 219
Lines 13608 13608
==========================================
+ Hits 11496 11499 +3
+ Misses 1741 1739 -2
+ Partials 371 370 -1 ☔ View full report in Codecov by Sentry. |
|
/lgtm /hold have you checked the logs printed if they are too verbose? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold We initially had a failed build, thus the pinning. The verbose log was in 1.5.1 which we did not use. |
Fixes #14597
Proposed Changes
SetCloseHandler()gorilla/websocket#863 are completed/assign @skonto