Skip to content

Copy all the source code from serving-operator repo to new repo #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow-robot merged 8 commits into from
Apr 3, 2020
Merged

Copy all the source code from serving-operator repo to new repo #1

knative-prow-robot merged 8 commits into from
Apr 3, 2020

Conversation

@houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Mar 31, 2020 •
edited
Loading

Proposed Changes

  • This PR is based on the commit d0e771a0a4adb9893b9e7af9c9eb866f9dd937df of serving-operator repo.
  • We replace /serving-operator/ with /operator/ to fit the new repo.
  • We can issue the command ko apply -f config to launch the operator of serving.

Release Note

@houshengbo houshengbo mentioned this pull request Mar 31, 2020
Merged
@evankanderson
Copy link
Member

evankanderson commented Mar 31, 2020

/help

@evankanderson
Copy link
Member

evankanderson commented Mar 31, 2020

/assign @aliok @jondonovan

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 31, 2020

@evankanderson: GitHub didn't allow me to assign the following users: aliok, jondonovan.

Note that only knative-sandbox members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @aliok @jondonovan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@houshengbo
Copy link
Contributor Author

houshengbo commented Mar 31, 2020

/retest

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 31, 2020

@houshengbo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@houshengbo
Copy link
Contributor Author

houshengbo commented Mar 31, 2020

/ok-to-test

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 31, 2020

@houshengbo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@houshengbo
Copy link
Contributor Author

houshengbo commented Mar 31, 2020

/retest

@houshengbo houshengbo force-pushed the add-serving-operator branch from f9de81f to 621088a Compare March 31, 2020 23:23
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Mar 31, 2020
@houshengbo houshengbo force-pushed the add-serving-operator branch 6 times, most recently from fdaf419 to 70e880d Compare April 1, 2020 00:33
@houshengbo houshengbo force-pushed the add-serving-operator branch from 70e880d to ab3c8b2 Compare April 3, 2020 17:48
@evankanderson
Copy link
Member

evankanderson commented Apr 3, 2020

/retest

@houshengbo houshengbo force-pushed the add-serving-operator branch from ab3c8b2 to 1bcfe26 Compare April 3, 2020 18:31
@knative-prow-robot knative-prow-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 3, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 3, 2020

@houshengbo: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-sandbox-operator-go-coverage 53755d3 link /test pull-knative-sandbox-operator-go-coverage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k4leung4
Copy link

k4leung4 commented Apr 3, 2020

/approve

@k4leung4
Copy link

k4leung4 commented Apr 3, 2020

/lgtm

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 3, 2020

@k4leung4: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, k4leung4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chaodaiG
Copy link

chaodaiG commented Apr 3, 2020

/lgtm

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 3, 2020

@chaodaiG: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chaodaiG
Copy link

chaodaiG commented Apr 3, 2020

Guess we need to join knative-sandbox org gaining power

@k4leung4
Copy link

k4leung4 commented Apr 3, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2020
@k4leung4
Copy link

k4leung4 commented Apr 3, 2020

@googlebot I consent.

@houshengbo houshengbo added the cla: yes Indicates the PR's author has signed the CLA. label Apr 3, 2020
@googlebot
Copy link

googlebot commented Apr 3, 2020

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot removed the cla: yes Indicates the PR's author has signed the CLA. label Apr 3, 2020
@aliok
Copy link
Member

aliok commented Apr 3, 2020

/lgtm

@houshengbo houshengbo added the cla: yes Indicates the PR's author has signed the CLA. label Apr 3, 2020
@googlebot
Copy link

googlebot commented Apr 3, 2020

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot removed the cla: yes Indicates the PR's author has signed the CLA. label Apr 3, 2020
@k4leung4
Copy link

k4leung4 commented Apr 3, 2020

@googlebot I consent.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 3, 2020
@knative-prow-robot knative-prow-robot merged commit f099a69 into knative:master Apr 3, 2020
@Cynocracy
Copy link

Cynocracy commented Apr 3, 2020

/lgtm

@Cynocracy
Copy link

Cynocracy commented Apr 3, 2020

aw, I'm late to the party :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aliok aliok

@k4leung4 k4leung4

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@houshengbo @evankanderson @knative-prow-robot @k4leung4 @chaodaiG @googlebot @aliok @Cynocracy