Remove obsolete resources caused by merging controllers #95
Conversation
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@aliok: 0 warnings.
Details
In response to this:
Issue to be fixed
Fixes #90
Proposed Changes
- Remove old resources that are obsolote after knative/eventing#2448
Release Note
NONEMore info on how to find what went obsolete is available at #90
How to verify:
- TBD
Notes:
- Replaced the
0.12.0.yamlinkodatawith the nightly release file (v20200206-05bba2be.yaml)- That nightly release file is fetched like this:
gsutil cp gs://knative-nightly/eventing/latest/eventing.yaml ./
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
cc @houshengbo |
|
Hi @aliok. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Removed the WIP status to see what tests do, but can somebody please add a |
|
/ok-to-test |
|
@aliok when we update the manifest, we need to update the version as well to match in version.go |
aliok
force-pushed
the
remove_obsolote_resources_0.13
branch
from
358c83b to
d87f294
Compare
|
@houshengbo I addressed your comments. Thanks for the feedback. As I said in #93, let's merge this PR first and then that one. See that PR for my reasons. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Issue to be fixed
Fixes #90
Proposed Changes
Release Note
More info on how to find what went obsolete is available at #90
How to verify:
Notes:
0.12.0.yamlinkodatawith the nightly release file (v20200206-05bba2be.yaml)gsutil cp gs://knative-nightly/eventing/latest/eventing.yaml ./