Add the registry into KnativeEventingSpec to support custom image registry #88
Conversation
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@houshengbo: 2 warnings.
Details
In response to this:
Issue to be fixed
Fixes #83
Proposed Changes
- This PR adds the support to download images from private registries for all the deployments.
Release Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
| @@ -0,0 +1,108 @@ | |||
| /* | |||
There was a problem hiding this comment.
Golint comments: package comment should be of the form "Package common ...". More info.
| containerNameVariable = "${NAME}" | ||
| ) | ||
|
|
||
| func DeploymentTransform(instance *eventingv1alpha1.KnativeEventing, log *zap.SugaredLogger) mf.Transformer { |
There was a problem hiding this comment.
Golint comments: exported function DeploymentTransform should have comment or be unexported. More info.
houshengbo
changed the title
houshengbo
force-pushed
the
add-registry
branch
from
1679f5c to
e87d94f
Compare
houshengbo
force-pushed
the
add-registry
branch
2 times, most recently
from
195ab5d to
aed4495
Compare
|
/test pull-knative-eventing-operator-go-coverage |
houshengbo
force-pushed
the
add-registry
branch
from
1fad26d to
8b7ff32
Compare
houshengbo
force-pushed
the
add-registry
branch
2 times, most recently
from
c198b9c to
274efcd
Compare
|
/test pull-knative-eventing-operator-go-coverage |
houshengbo
force-pushed
the
add-registry
branch
from
274efcd to
5894053
Compare
|
/test pull-knative-eventing-operator-go-coverage |
houshengbo
force-pushed
the
add-registry
branch
from
5894053 to
e5bf634
Compare
houshengbo
force-pushed
the
add-registry
branch
5 times, most recently
from
b917ac1 to
66fc2bc
Compare
houshengbo
force-pushed
the
add-registry
branch
2 times, most recently
from
53c0ea9 to
f6c06bc
Compare
houshengbo
force-pushed
the
add-registry
branch
from
f6c06bc to
5db04a1
Compare
houshengbo
force-pushed
the
add-registry
branch
from
5db04a1 to
4b935bb
Compare
|
The following is the coverage report on the affected files.
|
aliok
left a comment
aliok
left a comment
There was a problem hiding this comment.
/lgtm
Code added is basically a copy from serving operator, which is good as we know it works.
I guess we need to talk about the operator merging as this is kind of annoying.
We either need to move these code into a common library or we merge the operators.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cc @k4leung4 UPDATE: I learnt that this is normal. See https://knative.slack.com/archives/C92U2C59P/p1581684071154100?thread_ts=1581595563.134600&cid=C92U2C59P |
|
/joke |
|
@matzew: Why did the melons plan a big wedding? Because they cantaloupe! DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Issue to be fixed
Fixes #83
Proposed Changes
Release Note