Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Add the controller and reconciler to watch and convert the old CR #75

Merged
knative-prow-robot merged 5 commits into from
Jan 22, 2020
Merged

Add the controller and reconciler to watch and convert the old CR #75

knative-prow-robot merged 5 commits into from
Jan 22, 2020

Conversation

@houshengbo
Copy link

@houshengbo houshengbo commented Jan 21, 2020 •
edited
Loading

Issue to be fixed

Fixes #74

Proposed Changes

  • The CRD of the eventing-operator used to have a different Kind name at the version 0.11.0 and prior. We need to implement the CR conversion, so the latest version of the operator can recognize the old version CR and still work with the old CR. This PR will convert the old CR into the new CR if necessary.

Release Note

knative-prow-robot
knative-prow-robot reviewed Jan 21, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houshengbo: 1 warning.

Details

In response to this:

Issue to be fixed

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/reconciler/knativeeventing/knativeeventingobsolete.go Outdated
"knative.dev/eventing-operator/pkg/reconciler"
)

// Reconciler implements controller.Reconciler for Knativeeventing resources.
Copy link
Contributor

@knative-prow-robot knative-prow-robot Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Golint comments: comment on exported type ReconcilerObsolete should be of the form "ReconcilerObsolete ..." (with optional leading article). More info.

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jan 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@houshengbo houshengbo force-pushed the cr-conversion branch 2 times, most recently from 0f2933e to a61353f Compare January 21, 2020 21:58
@houshengbo houshengbo force-pushed the cr-conversion branch 4 times, most recently from 90b9e3c to dcbd348 Compare January 22, 2020 02:16
@houshengbo houshengbo changed the title WIP: Add the controller and reconciler to watch and convert the old CR Add the controller and reconciler to watch and convert the old CR Jan 22, 2020
@houshengbo houshengbo force-pushed the cr-conversion branch 3 times, most recently from 69ce784 to b55143b Compare January 22, 2020 17:56
@n3wscott
Copy link
Contributor

n3wscott commented Jan 22, 2020

/lgtm

@knative-prow-robot knative-prow-robot merged commit 0a0f486 into knative:master Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bbrowning bbrowning Awaiting requested review from bbrowning

@matzew matzew Awaiting requested review from matzew

2 more reviewers

@mattmoor mattmoor mattmoor left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@n3wscott n3wscott

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create an new CR of KnativeEventing, if old CR Eventing exists

4 participants

@houshengbo @knative-prow-robot @n3wscott @mattmoor