Have OLM metadata in source repo for reference #69
Conversation
|
Hi @aliok. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
aliok
changed the title
|
/ok-to-test |
| keywords: | ||
| - serverless | ||
| - eventing | ||
| - camel |
There was a problem hiding this comment.
+1, let me get rid of those here and also in operatorHub
| plural: eventings | ||
| singular: eventing | ||
| shortNames: | ||
| - ke |
There was a problem hiding this comment.
hmm, I started this PR before the shortname discussion. What's the latest situation there ? 🤣
There was a problem hiding this comment.
Short names should be removed, upstream already merged #48
There was a problem hiding this comment.
hmm, hold on :)
this OLM metadata is for the 0.11 version of the operator. In that version, short name is still there: https://github.com/knative/eventing-operator/blob/v0.11.0/config/300-eventing-v1alpha1-knativeeventing-crd.yaml#L12
So, let's keep this one for consistency. The CRD in this PR is identical to https://github.com/knative/eventing-operator/blob/v0.11.0/config/300-eventing-v1alpha1-knativeeventing-crd.yaml#L12
houshengbo
left a comment
houshengbo
left a comment
There was a problem hiding this comment.
/lgtm
Thanks to @aliok for working on the operator submission to operatorhub.
In future releases, we get rid of the short names.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Created operator-framework/community-operators#1108 for fixing the metadata in OperatorHub |
5 participants
Fixes #68