Add version consistency test #42
Conversation
|
Hi @aliok. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| continue | ||
| } | ||
| if v != expectedLabelValue { | ||
| t.Errorf("Version info in manifest and operator don't match. got: %v, want: %v. Resource GVK: %v, Resource name: %v", v, expectedLabelValue, |
There was a problem hiding this comment.
If version info doesn't match, it shows this message multiple times, for each resource in the manifest.
Alternatively, we can switch to failing eagerly with Fatalf
|
/assign @houshengbo @matzew |
|
/ok-to-test |
| var ( | ||
| // Version is the version that will be applied to the KnativeServing resource. | ||
| Version = "0.10.0" | ||
| Version = "0.10.1" |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@matzew need a new /lgtm . Fixed the test config error. |
|
/lgtm |
3 participants
Fixes #23