Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Letting flags be changed from outside #21

Merged
knative-prow-robot merged 1 commit into from
Oct 30, 2019
Merged

Letting flags be changed from outside #21

knative-prow-robot merged 1 commit into from
Oct 30, 2019

Conversation

@cardil
Copy link
Contributor

@cardil cardil commented Oct 30, 2019

This PR let change test flags from outside. It can be done either by:

  • declaring environmental variables: TEST_NAMESPACE, and TEST_RESOURCE,
  • using -ldflags "-X knative.dev/eventing-operator/test.EventingOperatorNamespace=knative-eventing"

Changing those flags is needed to perform tests on RH operators.

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Oct 30, 2019

Hi @cardil. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@n3wscott
Copy link
Contributor

n3wscott commented Oct 30, 2019

/ok-to-test
/approve
/lgtm
/hold
Hold for waiting for #17 to land, and then we can /retest to confirm it does not break the new unit tests.

@matzew
Copy link
Member

matzew commented Oct 30, 2019

/retest

@chizhg
Copy link

chizhg commented Oct 30, 2019

/test all

@matzew
Copy link
Member

matzew commented Oct 30, 2019

hrm...
a push -f for sure does the trick ... :-)

@cardil

houshengbo
houshengbo approved these changes Oct 30, 2019
View reviewed changes
Copy link

@houshengbo houshengbo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Oct 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, houshengbo, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [houshengbo,n3wscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@houshengbo
Copy link

houshengbo commented Oct 30, 2019

/hold cancel

@knative-prow-robot knative-prow-robot merged commit 050234e into knative:master Oct 30, 2019
@cardil cardil deleted the bugfix/let-chenge-test-flags branch October 31, 2019 09:19
@cardil cardil mentioned this pull request Nov 14, 2019
Merged
matzew added a commit to matzew/eventing-operator that referenced this pull request May 6, 2020
@matzew
Merge pull request knative#21 from matzew/1.7.z_stream_fix_SRVKE-403
c85b7b6 
Remove resources, like done on upstream
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@n3wscott n3wscott Awaiting requested review from n3wscott

1 more reviewer

@houshengbo houshengbo houshengbo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@n3wscott n3wscott

Labels

approved lgtm ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cardil @knative-prow-robot @n3wscott @matzew @chizhg @houshengbo