Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Add support of configuring ConfigMaps with CR (#197) #198

Merged
houshengbo merged 1 commit into from
Apr 20, 2020
Merged

Add support of configuring ConfigMaps with CR (#197) #198

houshengbo merged 1 commit into from
Apr 20, 2020

Conversation

@houshengbo
Copy link

@houshengbo houshengbo commented Apr 20, 2020

  • Add support of configuring ConfigMap with CR

  • Use 0.13.3 as the previous release version

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

Co-authored-by: Matt Moore [email protected]

Issue to be fixed

Fixes #

Proposed Changes

Release Note

@mattmoor
Add support of configuring ConfigMaps with CR (knative#197)
0005671 
* Add support of configuring ConfigMap with CR

* Use 0.13.3 as the previous release version

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

Co-authored-by: Matt Moore <[email protected]>
@googlebot
Copy link

googlebot commented Apr 20, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

knative-prow-robot
knative-prow-robot reviewed Apr 20, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houshengbo: 0 warnings.

Details

In response to this:

  • Add support of configuring ConfigMap with CR

  • Use 0.13.3 as the previous release version

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

  • Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore [email protected]

Co-authored-by: Matt Moore [email protected]

Issue to be fixed

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@houshengbo houshengbo merged commit 2c28a3a into knative:release-0.14 Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cynocracy Cynocracy Awaiting requested review from Cynocracy

@n3wscott n3wscott Awaiting requested review from n3wscott

1 more reviewer

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved cla: no size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@houshengbo @googlebot @knative-prow-robot