Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Add support of configuring ConfigMaps with CR #197

Merged
houshengbo merged 9 commits into from
Apr 20, 2020
Merged

Add support of configuring ConfigMaps with CR #197

houshengbo merged 9 commits into from
Apr 20, 2020

Conversation

@houshengbo
Copy link

@houshengbo houshengbo commented Apr 20, 2020 •
edited
Loading

Issue to be fixed

This PR copied everything from serving-operator repository, to implement the Tranform for ConfigMaps.

Proposed Changes

  • This PR added a new field called config in eventing operator CR to support ConfigMap editing.

Release Note

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow-robot
knative-prow-robot reviewed Apr 20, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houshengbo: 2 warnings.

Details

In response to this:

Issue to be fixed

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mattmoor
mattmoor reviewed Apr 20, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor
mattmoor reviewed Apr 20, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor
mattmoor reviewed Apr 20, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor
mattmoor reviewed Apr 20, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor
mattmoor reviewed Apr 20, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor
mattmoor reviewed Apr 20, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

pkg/reconciler/knativeeventing/common/config_maps_test.go
Comment on lines +36 to +39
name string
config configMapData
configMap corev1.ConfigMap
expected corev1.ConfigMap
Copy link
Member

@mattmoor mattmoor Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format Go code:

Suggested change
name string
config configMapData
configMap corev1.ConfigMap
expected corev1.ConfigMap
name string
config configMapData
configMap corev1.ConfigMap
expected corev1.ConfigMap

@knative-metrics-robot
Copy link

knative-metrics-robot commented Apr 20, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/knativeeventing/common/config_maps.go Do not exist 92.3%

@houshengbo houshengbo changed the title Add support of configuring ConfigMap with CR Add support of configuring ConfigMaps with CR Apr 20, 2020
@houshengbo houshengbo merged commit 8afd85c into knative:master Apr 20, 2020
houshengbo pushed a commit to houshengbo/eventing-operator that referenced this pull request Apr 20, 2020
@mattmoor
Add support of configuring ConfigMaps with CR (knative#197)
0005671 
* Add support of configuring ConfigMap with CR

* Use 0.13.3 as the previous release version

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

Co-authored-by: Matt Moore <[email protected]>
houshengbo pushed a commit that referenced this pull request Apr 20, 2020
@mattmoor
Add support of configuring ConfigMaps with CR (#197) (#198)
2c28a3a 
* Add support of configuring ConfigMap with CR

* Use 0.13.3 as the previous release version

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

Co-authored-by: Matt Moore <[email protected]>

Co-authored-by: Matt Moore <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aliok aliok Awaiting requested review from aliok

@Cynocracy Cynocracy Awaiting requested review from Cynocracy

2 more reviewers

@mattmoor mattmoor mattmoor left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved cla: yes size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@houshengbo @knative-prow-robot @knative-metrics-robot @mattmoor @googlebot