Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Conversation

@houshengbo
Copy link

This PR is a pick of the commit 0b41852 in master, since the updated manifestival package supports the overriding of the image with Env Variables.

Jon Donovan and others added 2 commits April 3, 2020 11:58
* Update manifestival to 0.4,0

* Fix changed method names.

* Forgot to add --all.
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@houshengbo houshengbo changed the title Pick manifest Update manifestival to 0.4.0 Apr 3, 2020
@k4leung4
Copy link
Contributor

k4leung4 commented Apr 3, 2020

/lgtm

@knative-prow-robot knative-prow-robot merged commit e0e5a86 into knative:release-0.13 Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants