Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Conversation

@houshengbo
Copy link

This PR adds only one unit test, but it will make sure the continuous build won't fail.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@houshengbo houshengbo force-pushed the add-unit-test branch 3 times, most recently from 15ff17c to 2360af7 Compare October 29, 2019 01:44
@houshengbo houshengbo force-pushed the add-unit-test branch 2 times, most recently from 5e044e7 to e8d7854 Compare October 29, 2019 01:58
@houshengbo houshengbo changed the title Add first unit test to test the GroupVersionKind Add first group of unit tests to test the eveting lifecycle Oct 29, 2019
This PR adds only one unit test, but it will make sure the continuous
build won't fail.
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1alpha1/knativeeventing_lifecycle.go Do not exist 88.9%
pkg/apis/eventing/v1alpha1/register.go Do not exist 100.0%

@houshengbo houshengbo changed the title Add first group of unit tests to test the eveting lifecycle Add first group of unit tests to test the eventing lifecycle Oct 30, 2019
@n3wscott
Copy link
Contributor

/lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants