-
Notifications
You must be signed in to change notification settings - Fork 26
Override images in env vars #152
Override images in env vars #152
Conversation
knative-prow-robot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aliok: 0 warnings.
Details
In response to this:
Issue to be fixed
Fixes #147
Proposed Changes
- Also override images in env vars
Release Note
NONETo override images in env vars, simply add the env var name as the key in the override map.
Ex:
Deployment
apiVersion: apps/v1 kind: Deployment metadata: name: broker-controller namespace: knative-eventing spec: template: spec: serviceAccountName: eventing-controller containers: - name: broker-controller terminationMessagePolicy: FallbackToLogsOnError image: gcr.io/knative-releases/knative.dev/eventing/cmd/channel_broker@sha256:853e0d194223da4356af7c9a17c79afa0ef96b93fd956d5febb2b1f2be78c717 env: - name: BROKER_INGRESS_IMAGE value: gcr.io/knative-releases/knative.dev/eventing/cmd/broker/ingress@sha256:d080653ce0792a304ba388dcb1e360dc427d8556503e0a2603da26d261ac21e4CR
apiVersion: operator.knative.dev/v1alpha1 kind: KnativeEventing metadata: ... spec: registry: override: broker-controller: docker.io/my-broker-controller BROKER_INGRESS_IMAGE : docker.io/my-broker-ingressResult:
apiVersion: apps/v1 kind: Deployment metadata: name: broker-controller namespace: knative-eventing spec: template: spec: serviceAccountName: eventing-controller containers: - name: broker-controller terminationMessagePolicy: FallbackToLogsOnError image: docker.io/my-broker-controller env: - name: BROKER_INGRESS_IMAGE value: docker.io/my-broker-ingress
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
The following is the coverage report on the affected files.
|
houshengbo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Boskos failures. |
|
/retest |
|
To answer a question asked offline:; For example, cc @houshengbo |
(cherry picked from commit eaf1553)
…g-override Override images in env vars (knative#152)
(cherry picked from commit eaf1553)
Override images in env vars (knative#152)
Co-authored-by: Ali Ok <[email protected]>
Issue to be fixed
Fixes #147
Proposed Changes
Release Note
To override images in env vars, simply add the env var name as the key in the override map.
Ex:
Deployment
CR
Result: