Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Install from the manifest in a strict(er) order. #150

Closed
Cynocracy wants to merge 3 commits into from
Closed

Install from the manifest in a strict(er) order. #150

Cynocracy wants to merge 3 commits into from

Conversation

@Cynocracy
Copy link
Contributor

@Cynocracy Cynocracy commented Mar 25, 2020 •
edited
Loading

This order, Roles -> RoleBindings -> The Rest, prevents the operand from
needing to structure their manifest such that this ordering exists, while
allowing the Operator to use the bootstrapping mechanism described in
#109 to 'escalate' itself
into management of the Knative Eventing installation without a *** clusterrole.

Issue to be fixed

Fixes #

Proposed Changes

  • Install roles, then rolebindings, then the remainder of the manifest.

Release Note

Install from the manifest in a strict order.
eb0914d 
This order, Roles -> RoleBindings -> The Rest, prevents the operand from
needing to structure their manifest such that this ordering exists, while
allowing the Operator to use the bootstrapping mechanism described in
knative#109 to 'escalate' itself
into management of the Knative Eventing installation without a *** clusterrole.
knative-prow-robot
knative-prow-robot reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cynocracy: 0 warnings.

Details

In response to this:

This order, Roles -> RoleBindings -> The Rest, prevents the operand from
needing to structure their manifest such that this ordering exists, while
allowing the Operator to use the bootstrapping mechanism described in
#109 to 'escalate' itself
into management of the Knative Eventing installation without a *** clusterrole.

Issue to be fixed

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mattmoor
mattmoor reviewed Mar 25, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

@Cynocracy
Copy link
Contributor Author

Cynocracy commented Mar 25, 2020

/assign @matzew

@Cynocracy Cynocracy mentioned this pull request Mar 25, 2020
Merged
@k4leung4
Copy link
Contributor

k4leung4 commented Mar 25, 2020

/lgtm

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 25, 2020

New changes are detected. LGTM label has been removed.

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 25, 2020

@Cynocracy: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynocracy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 25, 2020

@Cynocracy: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-operator-build-tests 355359f link /test pull-knative-eventing-operator-build-tests
pull-knative-eventing-operator-integration-tests 355359f link /test pull-knative-eventing-operator-integration-tests
pull-knative-eventing-operator-upgrade-tests 355359f link /test pull-knative-eventing-operator-upgrade-tests
pull-knative-eventing-operator-go-coverage 355359f link /test pull-knative-eventing-operator-go-coverage
pull-knative-eventing-operator-unit-tests 355359f link /test pull-knative-eventing-operator-unit-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Cynocracy
Copy link
Contributor Author

Cynocracy commented Mar 25, 2020

Rebase'd

@Cynocracy
Copy link
Contributor Author

Cynocracy commented Mar 25, 2020

This ended up going in in #109

@Cynocracy Cynocracy closed this Mar 25, 2020
@Cynocracy Cynocracy deleted the roles-then-bindings branch March 25, 2020 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@houshengbo houshengbo Awaiting requested review from houshengbo

@matzew matzew Awaiting requested review from matzew

2 more reviewers

@mattmoor mattmoor mattmoor left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@matzew matzew

@k4leung4 k4leung4

Labels

approved cla: yes needs-rebase size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Cynocracy @k4leung4 @knative-prow-robot @mattmoor @matzew @googlebot