Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Conversation

@houshengbo
Copy link

@houshengbo houshengbo commented Feb 17, 2020

Issue to be fixed

Proposed Changes

  • This PR is a cherry-pick of commit 723874e, commit 96b789c and commit dc8dca3. Additional fixes have been done as well to resolve the conflicts or errors.
  • Update the library from jcrossley/manifestival to manifestival/manifestival.

Release Note

aliok and others added 2 commits February 17, 2020 10:27
* Add upgrade tests into the e2e-tests-latest-eventing

This PR adds the tests to verify the correct number and names of knative eventing
deployments.

The test tag postupgrade is added, marking the tests to run after upgrade to the
latest HEAD of operator, with the latest generated manifest of knative eventing.

* Add the installation of the previous release and upgrade to the latest

* Fixes this PR based on the latest comments
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houshengbo: 0 warnings.

Details

In response to this:

Issue to be fixed

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@houshengbo
Copy link
Author

@googlebot I consent

@houshengbo
Copy link
Author

@googlebot I consent.

@houshengbo houshengbo force-pushed the cherry-pick-0.12 branch 2 times, most recently from 7a1450a to bfdd4c4 Compare February 17, 2020 15:45
@houshengbo houshengbo changed the title Cherry pick 0.12 Cherry pick for release 0.12 to support KUBECONFIG in OLM Feb 17, 2020
@aliok
Copy link
Member

aliok commented Feb 18, 2020

@googlebot I consent

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@houshengbo
Copy link
Author

/hold I have new findings, still verifying.

@houshengbo houshengbo force-pushed the cherry-pick-0.12 branch 2 times, most recently from 6ca1922 to 6e07b01 Compare February 18, 2020 16:34
@houshengbo
Copy link
Author

/hold cancel

@k4leung4
Copy link
Contributor

/lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants