Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Build config consistently as per in serving #105

Merged
knative-prow-robot merged 1 commit into from
Feb 13, 2020
Merged

Build config consistently as per in serving #105

knative-prow-robot merged 1 commit into from
Feb 13, 2020

Conversation

@aliok
Copy link
Member

@aliok aliok commented Feb 13, 2020

Config building in main and in controller is now done using the same method. This was done in serving PR knative/serving-operator#293

cc @markusthoemmes

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 13, 2020

Hi @aliok. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markusthoemmes
Copy link
Contributor

markusthoemmes commented Feb 13, 2020

/ok-to-test

houshengbo
houshengbo approved these changes Feb 13, 2020
View reviewed changes
Copy link

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 96b789c into knative:master Feb 13, 2020
@aliok aliok deleted the consistent_config_build branch February 14, 2020 07:14
houshengbo pushed a commit to houshengbo/eventing-operator that referenced this pull request Feb 17, 2020
@aliok
Build config consistently as per in serving (knative#105)
adc76a9
knative-prow-robot pushed a commit that referenced this pull request Feb 18, 2020
@aliok
Cherry pick for release 0.12 to support KUBECONFIG in OLM (#110)
f301633 
* Build config consistently as per in serving (#105)

* Add upgrade tests into the e2e-tests-latest-eventing (#93)

* Add upgrade tests into the e2e-tests-latest-eventing

This PR adds the tests to verify the correct number and names of knative eventing
deployments.

The test tag postupgrade is added, marking the tests to run after upgrade to the
latest HEAD of operator, with the latest generated manifest of knative eventing.

* Add the installation of the previous release and upgrade to the latest

* Fixes this PR based on the latest comments

* Add additionalPrinterColumns (#98)

* Update the library from jcrossley3/manifestival to manifestival

Co-authored-by: Ali Ok <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@k4leung4 k4leung4 Awaiting requested review from k4leung4

@matzew matzew Awaiting requested review from matzew

1 more reviewer

@houshengbo houshengbo houshengbo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@houshengbo houshengbo

Labels

approved lgtm ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aliok @knative-prow-robot @markusthoemmes @houshengbo