Read Kubeconfig from env var if previous methods don't work #100
Conversation
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@aliok: 0 warnings.
Details
In response to this:
Issue to be fixed
Fixes #99
Proposed Changes
- Read
KUBECONFIGenv var, ifkubeconfigcommand line argument is empty- Backwards compatible change
Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
Hi @aliok. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This change fixes the Operator Hub checks. See operator-framework/community-operators#1218 for verification. |
aliok
force-pushed
the
read_kubeconfig_from_env_var
branch
from
00c5607 to
73321db
Compare
|
@houshengbo Changed as per your suggestion. It is a better way. Thanks a lot! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Issue to be fixed
Fixes #99
Proposed Changes
KUBECONFIGif the command line argument is emptyRelease Note
Why having this fixes the tests at Operator Hub?
Operator Hub tests work like this:
KUBECONFIGIn our case, operator was doing its work good, but was not using the proxy and thus the tests were unable to detect the operator's actions.