[release-1.19] adjust test to allow operator upgrade [skip-dot-release] #8663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
area/test-and-release
knative-prow
bot
added
approved
Member
Author
|
/hold I might fix operator instead |
knative-prow
bot
added
the
do-not-merge/hold
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.19 #8663 +/- ##
================================================
+ Coverage 51.43% 51.44% +0.01%
================================================
Files 400 400
Lines 25139 25139
================================================
+ Hits 12930 12933 +3
+ Misses 11428 11426 -2
+ Partials 781 780 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Actually I think this PR is the simpler work around |
Member
Author
Member
Author
|
/hold cancel |
knative-prow
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
merged commit 5b2ee4a
into
knative:release-1.19
39 of 40 checks passed
Member
|
Ah good catch. Thanks @dprotaso |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks - knative/operator#2120
The test is running eventing code from
mainwhich is deploying a config file that doesn't work with eventing v1.19This adjusts eventing 1.19 to allow ignored fields to unblock the upgrade