Merging sources and eventing controller. #2448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/L
knative-prow-robot
added
the
approved
n3wscott
force-pushed
the
controller-join
branch
2 times, most recently
from
e54701a to
e6f0125
Compare
mattmoor
reviewed
Jan 27, 2020
n3wscott
force-pushed
the
controller-join
branch
from
e6f0125 to
8ee96e4
Compare
mattmoor
reviewed
Jan 27, 2020
matzew
reviewed
Jan 27, 2020
| kind: ClusterRole | ||
| metadata: | ||
| name: knative-eventing-source-controller | ||
| name: knative-eventing-sources-controller |
Member
There was a problem hiding this comment.
should that rename be covered in the release notes ? 👀
Contributor
Author
There was a problem hiding this comment.
it is a cluster role and internal
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n3wscott, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
This is relevant for the eventing operator. |
This was referenced Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not make sense for Eventing and Sources to be shipped as separate controllers when SinkBinding is shipped inside the single webhook. It would be better for eventing core to be a smaller footprint into the cluster. This change makes Eventing core ship as one controller.
Proposed Changes
Release Note