Skip to content

Commit db313c1

Browse files
authored
feat: webhook validates new config-observability (#8633)
Signed-off-by: Calum Murray <[email protected]>
1 parent 4e3838c commit db313c1

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

cmd/webhook/main.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ import (
6767
sourcesv1 "knative.dev/eventing/pkg/apis/sources/v1"
6868
sourcesv1beta2 "knative.dev/eventing/pkg/apis/sources/v1beta2"
6969
"knative.dev/eventing/pkg/apis/sugar"
70+
o11yconfigmap "knative.dev/eventing/pkg/observability/configmap"
7071
"knative.dev/eventing/pkg/reconciler/sinkbinding"
7172

7273
versionedscheme "knative.dev/eventing/pkg/client/clientset/versioned/scheme"
@@ -213,8 +214,8 @@ func NewConfigValidationController(ctx context.Context, _ configmap.Watcher) *co
213214

214215
// The configmaps to validate.
215216
configmap.Constructors{
216-
tracingconfig.ConfigName: tracingconfig.NewTracingConfigFromConfigMap,
217-
// metrics.ConfigMapName(): metricsconfig.NewObservabilityConfigFromConfigMap,
217+
tracingconfig.ConfigName: tracingconfig.NewTracingConfigFromConfigMap,
218+
o11yconfigmap.Name(): o11yconfigmap.Parse,
218219
logging.ConfigMapName(): logging.NewConfigFromConfigMap,
219220
leaderelection.ConfigMapName(): leaderelection.NewConfigFromConfigMap,
220221
sugar.ConfigName: sugar.NewConfigFromConfigMap,

0 commit comments

Comments
 (0)