fix: preserve nil pointer types in Get() method - #397
Merged
Conversation
Asakuri
commented
Jan 24, 2026
Asakuri
commented
Contributor
- Changed Get() to return the original nil pointer value instead of untyped nil, preserving the pointer's type information
- Added type assertions in TestGetNilPointer to verify the returned nil values maintain their original types (*test, *[]string)
- Changed Get() to return the original nil pointer value instead of untyped nil, preserving the pointer's type information - Added type assertions in TestGetNilPointer to verify the returned nil values maintain their original types (*test, *[]string)
radermacher-iits
pushed a commit
to kubara-io/kubara
that referenced
this pull request
Feb 19, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/knadh/koanf/v2](https://github.com/knadh/koanf) | require | patch | `v2.3.0` → `v2.3.2` | --- ### Release Notes <details> <summary>knadh/koanf (github.com/knadh/koanf/v2)</summary> ### [`v2.3.2`](https://github.com/knadh/koanf/releases/tag/v2.3.2) [Compare Source](knadh/koanf@v2.3.1...v2.3.2) #### What's Changed - fix: preserve nil pointer types in Get() method by [@​Asakuri](https://github.com/Asakuri) in [#​397](knadh/koanf#397) #### New Contributors - [@​Asakuri](https://github.com/Asakuri) made their first contribution in [#​397](knadh/koanf#397) **Full Changelog**: <knadh/koanf@v2.3.1...v2.3.2> ### [`v2.3.1`](https://github.com/knadh/koanf/releases/tag/v2.3.1) [Compare Source](knadh/koanf@v2.3.0...v2.3.1) #### What's Changed - providers/cliflagv3: Set the flags if they have a default value by [@​xescugc](https://github.com/xescugc) in [#​382](knadh/koanf#382) - fix panic in dotenv parser when callback function is not provided by [@​nilsocket](https://github.com/nilsocket) in [#​387](knadh/koanf#387) - Bump golang.org/x/crypto from 0.40.0 to 0.45.0 in /providers/kiln by [@​dependabot](https://github.com/dependabot)\[bot] in [#​391](knadh/koanf#391) - Bump golang.org/x/crypto from 0.37.0 to 0.45.0 in /providers/nats by [@​dependabot](https://github.com/dependabot)\[bot] in [#​390](knadh/koanf#390) - refactor `interface{}` to `any` by [@​nilsocket](https://github.com/nilsocket) in [#​385](knadh/koanf#385) - fix: pass event to callback instead of nil when file changes detected by [@​josepdcs](https://github.com/josepdcs) in [#​384](knadh/koanf#384) #### New Contributors - [@​xescugc](https://github.com/xescugc) made their first contribution in [#​382](knadh/koanf#382) - [@​nilsocket](https://github.com/nilsocket) made their first contribution in [#​387](knadh/koanf#387) - [@​josepdcs](https://github.com/josepdcs) made their first contribution in [#​384](knadh/koanf#384) **Full Changelog**: <knadh/koanf@v2.3.0...v2.3.1> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Mi40IiwidXBkYXRlZEluVmVyIjoiNDIuOTIuNCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119--> Reviewed-on: https://kubara.git.onstackit.cloud/STACKIT/kubara/pulls/252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.