Skip to content

refactor interface{} to any - #385

Merged
knadh merged 2 commits into
knadh:masterfrom
nilsocket:refactor/any
Dec 19, 2025
Merged

refactor interface{} to any#385
knadh merged 2 commits into
knadh:masterfrom
nilsocket:refactor/any

Conversation

@nilsocket

Copy link
Copy Markdown
Contributor
  • Convert empty interface interface{} to any wherever possible.
  • Use sliceToLookupMap() helper function with generics to remove redundant code.

@rhnvrm
rhnvrm requested a review from Copilot October 30, 2025 06:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the codebase by replacing all occurrences of interface{} with the any type alias, which was introduced in Go 1.18 as a cleaner, more readable alternative. The changes are purely syntactic and maintain the same runtime behavior.

Key changes:

  • Replace interface{} with any throughout the entire codebase
  • Simplify duplicate logic in maps/maps.go by introducing a generic helper function
  • Remove extraneous blank line at end of parsers/huml/huml.go
  • Fix formatting/whitespace in several files

Reviewed Changes

Copilot reviewed 55 out of 55 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
koanf.go Updated core type definitions and method signatures from interface{} to any
interfaces.go Updated Provider and Parser interface signatures
options.go Updated merge function signature
getters.go Updated type assertions from interface{} to any
maps/maps.go Replaced interface{} with any and refactored duplicate functions using generics
parsers/*.go Updated parser Unmarshal/Marshal signatures across all parsers
providers/*.go Updated provider Read/Watch method signatures across all providers
tests/*.go Updated test fixtures and type declarations
examples/*.go Updated callback signatures in example code
README.md Updated documentation references

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread examples/default-values/main.go
@rhnvrm

rhnvrm commented Oct 30, 2025

Copy link
Copy Markdown
Collaborator

Looks good 👍

@knadh
knadh merged commit 45d1dc2 into knadh:master Dec 19, 2025
9 checks passed
radermacher-iits pushed a commit to kubara-io/kubara that referenced this pull request Feb 19, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/knadh/koanf/v2](https://github.com/knadh/koanf) | require | patch | `v2.3.0` → `v2.3.2` |

---

### Release Notes

<details>
<summary>knadh/koanf (github.com/knadh/koanf/v2)</summary>

### [`v2.3.2`](https://github.com/knadh/koanf/releases/tag/v2.3.2)

[Compare Source](knadh/koanf@v2.3.1...v2.3.2)

#### What's Changed

- fix: preserve nil pointer types in Get() method by [@&#8203;Asakuri](https://github.com/Asakuri) in [#&#8203;397](knadh/koanf#397)

#### New Contributors

- [@&#8203;Asakuri](https://github.com/Asakuri) made their first contribution in [#&#8203;397](knadh/koanf#397)

**Full Changelog**: <knadh/koanf@v2.3.1...v2.3.2>

### [`v2.3.1`](https://github.com/knadh/koanf/releases/tag/v2.3.1)

[Compare Source](knadh/koanf@v2.3.0...v2.3.1)

#### What's Changed

- providers/cliflagv3: Set the flags if they have a default value by [@&#8203;xescugc](https://github.com/xescugc) in [#&#8203;382](knadh/koanf#382)
- fix panic in dotenv parser when callback function is not provided by [@&#8203;nilsocket](https://github.com/nilsocket) in [#&#8203;387](knadh/koanf#387)
- Bump golang.org/x/crypto from 0.40.0 to 0.45.0 in /providers/kiln by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;391](knadh/koanf#391)
- Bump golang.org/x/crypto from 0.37.0 to 0.45.0 in /providers/nats by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;390](knadh/koanf#390)
- refactor  `interface{}` to `any` by [@&#8203;nilsocket](https://github.com/nilsocket) in [#&#8203;385](knadh/koanf#385)
- fix: pass event to callback instead of nil when file changes detected by [@&#8203;josepdcs](https://github.com/josepdcs) in [#&#8203;384](knadh/koanf#384)

#### New Contributors

- [@&#8203;xescugc](https://github.com/xescugc) made their first contribution in [#&#8203;382](knadh/koanf#382)
- [@&#8203;nilsocket](https://github.com/nilsocket) made their first contribution in [#&#8203;387](knadh/koanf#387)
- [@&#8203;josepdcs](https://github.com/josepdcs) made their first contribution in [#&#8203;384](knadh/koanf#384)

**Full Changelog**: <knadh/koanf@v2.3.0...v2.3.1>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Mi40IiwidXBkYXRlZEluVmVyIjoiNDIuOTIuNCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119-->

Reviewed-on: https://kubara.git.onstackit.cloud/STACKIT/kubara/pulls/252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants