Skip to content

providers/cliflagv3: Set the flags if they have a default value - #382

Merged
knadh merged 1 commit into
knadh:masterfrom
xescugc:fg-cliflagv3_defaults
Sep 29, 2025
Merged

providers/cliflagv3: Set the flags if they have a default value#382
knadh merged 1 commit into
knadh:masterfrom
xescugc:fg-cliflagv3_defaults

Conversation

@xescugc

@xescugc xescugc commented Sep 28, 2025

Copy link
Copy Markdown
Contributor

Before those needed to be manually set with '--flag-name' or with the 'Config' whic is really anoying to do. So now flags with 'Value'(default) will be also by default set to the output. It should be the 'default' behavior

Before those needed to be manually set with '--flag-name' or with the 'Config' whic
is really anoying to do. So now flags with 'Value'(default) will be also by default
set to the output. It should be the 'default' behavior
@knadh
knadh merged commit e38d5b4 into knadh:master Sep 29, 2025
3 checks passed
@xescugc
xescugc deleted the fg-cliflagv3_defaults branch September 30, 2025 07:53
radermacher-iits pushed a commit to kubara-io/kubara that referenced this pull request Feb 19, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/knadh/koanf/v2](https://github.com/knadh/koanf) | require | patch | `v2.3.0` → `v2.3.2` |

---

### Release Notes

<details>
<summary>knadh/koanf (github.com/knadh/koanf/v2)</summary>

### [`v2.3.2`](https://github.com/knadh/koanf/releases/tag/v2.3.2)

[Compare Source](knadh/koanf@v2.3.1...v2.3.2)

#### What's Changed

- fix: preserve nil pointer types in Get() method by [@&#8203;Asakuri](https://github.com/Asakuri) in [#&#8203;397](knadh/koanf#397)

#### New Contributors

- [@&#8203;Asakuri](https://github.com/Asakuri) made their first contribution in [#&#8203;397](knadh/koanf#397)

**Full Changelog**: <knadh/koanf@v2.3.1...v2.3.2>

### [`v2.3.1`](https://github.com/knadh/koanf/releases/tag/v2.3.1)

[Compare Source](knadh/koanf@v2.3.0...v2.3.1)

#### What's Changed

- providers/cliflagv3: Set the flags if they have a default value by [@&#8203;xescugc](https://github.com/xescugc) in [#&#8203;382](knadh/koanf#382)
- fix panic in dotenv parser when callback function is not provided by [@&#8203;nilsocket](https://github.com/nilsocket) in [#&#8203;387](knadh/koanf#387)
- Bump golang.org/x/crypto from 0.40.0 to 0.45.0 in /providers/kiln by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;391](knadh/koanf#391)
- Bump golang.org/x/crypto from 0.37.0 to 0.45.0 in /providers/nats by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;390](knadh/koanf#390)
- refactor  `interface{}` to `any` by [@&#8203;nilsocket](https://github.com/nilsocket) in [#&#8203;385](knadh/koanf#385)
- fix: pass event to callback instead of nil when file changes detected by [@&#8203;josepdcs](https://github.com/josepdcs) in [#&#8203;384](knadh/koanf#384)

#### New Contributors

- [@&#8203;xescugc](https://github.com/xescugc) made their first contribution in [#&#8203;382](knadh/koanf#382)
- [@&#8203;nilsocket](https://github.com/nilsocket) made their first contribution in [#&#8203;387](knadh/koanf#387)
- [@&#8203;josepdcs](https://github.com/josepdcs) made their first contribution in [#&#8203;384](knadh/koanf#384)

**Full Changelog**: <knadh/koanf@v2.3.0...v2.3.1>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Mi40IiwidXBkYXRlZEluVmVyIjoiNDIuOTIuNCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119-->

Reviewed-on: https://kubara.git.onstackit.cloud/STACKIT/kubara/pulls/252
knadh added a commit that referenced this pull request Mar 14, 2026
…g()` just like `posflag`.

Closes #402. Fixes the incorrect solution in #382.
@knadh

knadh commented Mar 14, 2026

Copy link
Copy Markdown
Owner

Please see #402 and the PR #403.

The p.cmd.Value(name) != nil patch in this PR was a mistake. The better way to solve is to take the approach that basicflag/posflag does, which is taking another instance of koanf.

knadh added a commit that referenced this pull request Mar 20, 2026
…g()` just like `posflag`. (#403)

Closes #402. Fixes the incorrect solution in #382.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants