docs: Add warnings about hard reboot mode and clarify soft mode behavior#260
Closed
jtollet wants to merge 4 commits intokmscon:mainfrom
Closed
docs: Add warnings about hard reboot mode and clarify soft mode behavior#260jtollet wants to merge 4 commits intokmscon:mainfrom
jtollet wants to merge 4 commits intokmscon:mainfrom
Conversation
Following Karlson2k's feedback on PR kmscon#176, this commit adds clear warnings about the dangers of "hard" mode (immediate reboot without proper shutdown) which can cause data loss and filesystem corruption. The documentation now explicitly states that: - "soft" mode (default) sends SIGINT to PID 1 for a clean reboot, matching the standard Linux console Ctrl-Alt-Del behavior - "hard" mode performs an immediate reboot via reboot(RB_AUTOBOOT) with sync() but without proper shutdown sequence Changes: - Updated man pages (kmscon.1 and kmscon.conf.1) with detailed warnings - Updated kmscon.conf.example with prominent DATA LOSS warning - Clarified that soft mode matches Linux console behavior users expect Tested on real hardware with both modes: - soft mode: clean shutdown via SIGINT to PID 1 ✓ - hard mode: immediate reboot via RB_AUTOBOOT ✓
Contributor
|
Thanks for your contribution. However I feel like adding a new parameter is a bit too much. I would prefer either always using the "soft reboot", or reading /proc/sys/kernel/ctrl-alt-del and acting accordingly.
|
Contributor
Author
|
Thank you for the feedback! I've created a new PR that implements your suggested approach of reading /proc/sys/kernel/ctrl-alt-del instead of adding a new parameter: #264 This PR can be closed as it's superseded by the new approach. |
Contributor
Author
|
Closing in favor of #264 which implements the suggested approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following @Karlson2k's feedback on PR #176, this PR adds clear warnings about the dangers of "hard" mode (immediate reboot without proper shutdown) which can cause data loss and filesystem corruption.
Changes
Documentation Updates
The documentation now explicitly states that:
Testing
Both modes have been tested on real hardware:
This addresses the concerns raised in #176 (comment)