units: drop unnecessary templating of units#246
Merged
kdj0c merged 1 commit intokmscon:mainfrom Jan 26, 2026
Merged
Conversation
Contributor
Author
|
I don't understand why github thinks that there's a conflict. I don't see it. |
Systemd stopped requiring an absolute path in ExecStart= in systemd 239 (2018). It is nicer to keep the unit files the same everywhere, so drop the templating. While at it, drop the explicit mode setting. rw-r--r-- is the default unless overriden.
Contributor
|
it looks like your branch is based on an old commit 04dca3c Remove bblit renderer and make bbulk built-in. |
kdj0c
force-pushed
the
do-not-template-units
branch
from
ae25ba7 to
c6abc32
Compare
Contributor
|
I fixed it, it should be good now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Systemd stopped requiring an absolute path in ExecStart= in systemd 239 (2018). It is nicer to keep the unit files the same everywhere, so drop the templating.
While at it, drop the explicit mode setting. rw-r--r-- is the default unless overriden.