Merged
Conversation
Sometime kmscon crashes with the following stack trace:
Module libxkbcommon.so.0 from rpm libxkbcommon-1.8.1-1.fc42.x86_64
Stack trace of thread 6732:
#0 0x00007f8b79de9974 calc_line_len (libtsm.so.4 + 0x3974)
Aetf#1 0x00007f8b79dea153 copy_lines (libtsm.so.4 + 0x4153)
Aetf#2 0x000000000040cd7b copy_selection (/usr/local/libexec/kmscon/kmscon + 0xcd7b)
Aetf#3 0x000000000041d3bd shl_hook_call (/usr/local/libexec/kmscon/kmscon + 0x1d3bd)
Aetf#4 0x000000000041d9f6 pointer_dev_button (/usr/local/libexec/kmscon/kmscon + 0x1d9f6)
Aetf#5 0x000000000041b18d notify_event (/usr/local/libexec/kmscon/kmscon + 0x1b18d)
Aetf#6 0x0000000000411dd7 ev_eloop_dispatch (/usr/local/libexec/kmscon/kmscon + 0x11dd7)
Aetf#7 0x00000000004124e2 ev_eloop_run (/usr/local/libexec/kmscon/kmscon + 0x124e2)
Aetf#8 0x0000000000401688 main (/usr/local/libexec/kmscon/kmscon + 0x1688)
Aetf#9 0x00007f8b79a76575 __libc_start_call_main (libc.so.6 + 0x3575)
Aetf#10 0x00007f8b79a76628 __libc_start_main@@GLIBC_2.34 (libc.so.6 + 0x3628)
Aetf#11 0x0000000000401a25 _start (/usr/local/libexec/kmscon/kmscon + 0x1a25)
The root cause is a off by one error in coord_to_cell(), so the
selected cell can be outside the terminal.
Signed-off-by: Jocelyn Falempe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometime kmscon crashes with the following stack trace:
The root cause is a off by one error in coord_to_cell(), so the selected cell can be outside the terminal.