Merged
Conversation
Contributor
|
Does this reuse mode instead of unconditional modeset event on every VT switch? |
Contributor
Author
|
Normally with Atomic modesetting, the driver is able to reprogram only what is needed. |
kdj0c
force-pushed
the
atomic
branch
6 times, most recently
from
efa9225 to
b20b1a8
Compare
added 8 commits
January 11, 2026 00:34
Split uterm_display_bind() in two steps. In the atomic drm use case, all displays of a video card must be setup together. So first enable all displays and then call the seat and terminal callback to make use of the available displays. The reason is that a GPU might be able to handle a 4K display on DP1 or on DP2, but not both at the same time. So the displays can't be setup independantly. Signed-off-by: Jocelyn Falempe <[email protected]>
All drm drivers supports atomic modesetting. Hopefully it won't break anything. There is still the fbdev backend for fallback compatibility. Signed-off-by: Jocelyn Falempe <[email protected]>
* use log_err() instead of log_error() * use ret value instead of errno. Signed-off-by: Jocelyn Falempe <[email protected]>
Use atomic commit to setup the display. All drm drivers support it now. This allows to test the commit before applying the mode, and is more reliable than the old method. Using https://github.com/dvdhrm/docs/blob/master/drm-howto/modeset-atomic.c as a base for atomic modesetting. Signed-off-by: Jocelyn Falempe <[email protected]>
It is no more used, after the switch to atomic modesetting Signed-off-by: Jocelyn Falempe <[email protected]>
This makes it a bit easier to debug multi-display issue. Signed-off-by: Jocelyn Falempe <[email protected]>
When terminal is initialized, and font added, but no display is attached yet, a warning is logged, but this is expected. So remove this warning, as it is normal behavior. Signed-off-by: Jocelyn Falempe <[email protected]>
When switching VT, between Gnome and kmscon, the gnome cursor can stay. Clear the CRTC_ID property of all cursor plane, to make sure they are disabled. Signed-off-by: Jocelyn Falempe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All DRM drivers have now support for atomic commit, which is more reliable than the legacy DRM API.
Re-organize the code, to do one atomic commit for all displays, and separate page flips from real modeset.