Merged
Conversation
added 2 commits
December 9, 2025 17:22
drm2d directly calls the ioctl, but it's cleaner to use the libdrm's helpers. Addfb is deprecated for a long time, so use Addfb2, which allows to specify the pixel format. Signed-off-by: Jocelyn Falempe <[email protected]>
drmModeAddFB is deprecated, as the pixel format can't be specified Also gbm_bo_get_stride() replaced gbm_bo_get_pitch 13 years ago. Signed-off-by: Jocelyn Falempe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses libdrm helpers, and use drmModeAddFB2().