More extensive kmscon-launch-gui.sh tweaks, inotifywait#163
Merged
kdj0c merged 4 commits intokmscon:mainfrom Dec 9, 2025
Merged
More extensive kmscon-launch-gui.sh tweaks, inotifywait#163kdj0c merged 4 commits intokmscon:mainfrom
kdj0c merged 4 commits intokmscon:mainfrom
Conversation
kdj0c
reviewed
Dec 5, 2025
Contributor
kdj0c
left a comment
kdj0c
left a comment
There was a problem hiding this comment.
Thanks for this PR, I agree with most of the changes.
Please update it, and I will merge it.
Fixed printf syntax to be portable and work in dash. Got rid of useless `cat`s. Signed-off-by: Vladimir-csp <[email protected]>
Signed-off-by: Vladimir-csp <[email protected]>
Contributor
|
Sorry, I pushed to your branch, because I wanted to cleaned-up the commit history, the content should be the same. |
Closed
Contributor
Author
|
Corrected a dumb mistake, sorry. |
Use `inotifywait` to monitor foreground console change, if available, otherwise fallback to sleep. Use `case` for control sequence selectors as it is more compact, elegant, and handy for potential future variant additions. apply `shfmt -s -sr` formatting. Signed-off-by: Vladimir-csp <[email protected]>
Use single quotes to reduce escape ambiguity. There are no variables in those strings, now there is one less backslash, result is the same: ``` printf '%b' "\033Ptmux;\033\033]setBackground\a\033\\" | md5sum printf '%b' '\033Ptmux;\033\033]setBackground\a\033\' | md5sum ``` ``` f5a7f67be35dcd7b910e05f52cf1676a - f5a7f67be35dcd7b910e05f52cf1676a - ``` Signed-off-by: Vladimir-csp <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #162
Use
inotifywaitto monitor foreground console change, if available, otherwise fallback to sleep.Use
casefor control sequence selectors as it is more compact, elegant, and handy for potential future variant additions.apply
shfmt -s -srformatting.