fix(translations): correct inverted French notifications switch label (#114)#116
Merged
Conversation
…#114) The ws_suppress_notifications switch uses inverted logic (ON = notifications enabled, suppress=False). English and all other locales label it "Enable HA Notifications", but French read "Bloquer les notifications HA" (Block), the opposite meaning. French users turning the switch ON to block notifications were actually enabling them, so HA Repairs alerts (e.g. stale-sensor warnings) kept appearing. Relabel to "Activer les notifications HA" to match the switch behaviour and every other locale. Co-Authored-By: Claude Opus 4.8 <[email protected]>
…rg-65f104 # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the French label of the
ws_suppress_notificationsswitch, which was the opposite of its actual behaviour.The switch uses
inverted=Truelogic (switch.py): switch ON = notifications enabled (suppress_notifications=False). English and every other locale (de/es/it/nl/pl/pt) label it "Enable HA Notifications", matching the behaviour. French alone read "Bloquer les notifications HA" ("Block HA notifications") - the opposite meaning.As a result, a French user who turned the switch ON to block notifications was actually setting
suppress=Falseand enabling them. HA Repairs alerts (e.g. the stale-sensor warning) kept appearing, which is exactly the behaviour reported.The coordinator gating in
coordinator.py(if self.suppress_notifications: delete all issues) was correct all along; only the French label was wrong.Related Issue
Closes #114
Motivation and Context
The reporter writes in French and followed the French label, getting the inverse of the intended effect.
How Has This Been Tested?
python -m pytest -q→ 259 passedfr.jsonvalidated as parseable JSONinverted=Trueswitch logic and all other localesTypes of changes
Checklist:
🤖 Generated with Claude Code