fix(translations): fix fr.json structure causing all French strings to be ignored#112
Merged
Conversation
…o be ignored indoor_rooms_opt and all subsequent options flow steps were nested inside features_opt.data_description instead of being siblings of features_opt in options.step. Home Assistant silently discarded the malformed structure and fell back to English. Also removes a stale extra closing brace that was left over before PR #109. Closes #111 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
indoor_rooms_optand all subsequent options flow steps were nested insidefeatures_opt.data_descriptioninstead of being siblings offeatures_optinoptions.step}at the end of the file left from before PR Update fr.json #109The JSON was syntactically valid (which is why it was hard to spot), but structurally wrong at the schema level HA validates against.
Test plan
python -c "import json; json.load(open('custom_components/ws_core/translations/fr.json', encoding='utf-8'))"exits cleanlyCloses #111
🤖 Generated with Claude Code