Allow bypassing the initial axis calibration routine#87
Open
rafaellehmkuhl wants to merge 5 commits intokmamal:masterfrom
Open
Allow bypassing the initial axis calibration routine#87rafaellehmkuhl wants to merge 5 commits intokmamal:masterfrom
rafaellehmkuhl wants to merge 5 commits intokmamal:masterfrom
Conversation
Contributor
Author
|
Hi @kmamal! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This initial calibration routine appears to be happening on top of what SDL provides by default, and in our case it is causing the triggers from the users joysticks to be sending values out of the expected range.
What we saw happening was that, during startup, the joystick is usually sitting on a desk, and its unfortunately very common for the triggers to be slightly pressed, since they are usually the resting point in the back of the joystick. With them pressed during the startup, the initial calibration is seeing this press as an offset, and causing the original axis range to be modified.
The solution here is to add an extra argument during the opening of the device, which allows the user to bypass this initial calibration and take care of it from its application. The bypass is false by default, so there's no API break.
I'm open for feedback on both the feature and the implementation itself :)