Skip to content

Conversation

@simon-cj
Copy link
Contributor

What type of PR is this?
/kind feature
/area model

What this PR does / why we need it:
when exec ormb save and there are not ormbfile.yaml, generate ormbfile.yaml automatically

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @FogDong

Does this PR introduce a user-facing change?:

None

@caicloud-bot caicloud-bot requested a review from FogDong January 15, 2021 09:42
@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. area/model Model related functions, including model warehouse, model compression, model evaluation, etc. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2021
@simon-cj
Copy link
Contributor Author

comments are address, PTAL @FogDong

Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2021
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FogDong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2021
@caicloud-bot caicloud-bot merged commit 952e10a into kleveross:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/model Model related functions, including model warehouse, model compression, model evaluation, etc. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants