Skip to content

Conversation

@tskdsb
Copy link
Contributor

@tskdsb tskdsb commented Nov 17, 2020

What this PR does / why we need it:

For convenience, create the target directory when export

  • os.MkdirAll will do nothing if the directory already exists
  • The permission bits perm are used before umask

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #146

Reference to #

Special notes for your reviewer:

/cc @simon-cj

Release note:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2020
@simon-cj
Copy link
Contributor

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simon-cj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020
@caicloud-bot caicloud-bot merged commit b66c292 into kleveross:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] auto create directory when export a model

3 participants