Skip to content

ORMB python sdk setup.py imports requests before installing it #195

@gbolmier

Description

@gbolmier

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

setup.py imports git_release module which imports requests before this latter could actually be installed as specified by install_requires:

install_requires=[
"requests"
],

leading to installation failures of ORMB python sdk on systems that don't have the requests package pre-installed

What you expected to happen:

ORMB python sdk installation should not require pre-installed packages

How to reproduce it (as minimally and precisely as possible):

Create a virtual environment without installing requests and then pip install ormb

Anything else we need to know?:

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions