generated from caicloud/golang-template-project
-
Notifications
You must be signed in to change notification settings - Fork 63
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Description
Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
setup.py imports git_release module which imports requests before this latter could actually be installed as specified by install_requires:
ormb/extern-sdk/python/setup.py
Lines 33 to 35 in 0aae49a
| install_requires=[ | |
| "requests" | |
| ], |
leading to installation failures of ORMB python sdk on systems that don't have the requests package pre-installed
What you expected to happen:
ORMB python sdk installation should not require pre-installed packages
How to reproduce it (as minimally and precisely as possible):
Create a virtual environment without installing requests and then pip install ormb
Anything else we need to know?:
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.